Repository navigation
Remove support for Java 8 - #17466
Merged
Merged
Conversation
Akshat-Jain
marked this pull request as ready for review
November 11, 2024 04:23
…dated java version
…oogle.inject.extensions:guice-multibindings:jar:4.2.2:compile
1 of 9 tasks
kgyrtkirk
approved these changes
Nov 20, 2024
kgyrtkirk
left a comment
kgyrtkirk
left a comment
Member
There was a problem hiding this comment.
thank you for making this move!
couple things I was thinking about while I've reviewed these changes:
- upgrade apache parent pom to something which is more recent
- remove specific versions from build plugins (let the parent do it)
- finally we could upgrade the git-commit-id-plugin to a more recent version; it adds around 2 minutes to the project's sequential build time
- possibly remove the elephantbird from the twitter plugin
+1 thank you @Akshat-Jain !
Member
|
it looks like java 17 is still running in the second phase of unit tests, these can be removed i think since they replaced the java 8 tests in phase 1, https://github.com/apache/druid/blob/master/.github/workflows/unit-and-integration-tests-unified.yml#L165 (i think this should just be 11 and 21 now) |
Contributor
Author
|
@clintropolis Makes sense, have made the change. |
clintropolis
approved these changes
Nov 21, 2024
1 of 9 tasks
kgyrtkirk
pushed a commit
that referenced
this pull request
Nov 26, 2024
We have removed support for Java 8 in #17466. This PR removes an unused profile pre-java-11 which activated for JDK < 11.
1 of 9 tasks
3 of 10 tasks
This was referenced Dec 12, 2024
1 task done
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
All JDK 8 based CI checks have been removed.
Images used in Dockerfile(s) have been updated to Java 17 based images.
Documentation has been updated accordingly.
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
We have removed support for Java 8 in apache#17466. This PR removes an unused profile pre-java-11 which activated for JDK < 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting with Apache Druid 32.0.0, we want to remove the support for Java 8. This PR does that as follows:
Release note
Starting with Apache Druid 32.0.0, support for Java 8 has been removed.
This PR has: